fix(commands): Option not working with str / ForwardRef annotations #2919
+34
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! This pull request can be checked-out with: git fetch origin pull/2919/head:pr-2919
git checkout pr-2919This pull request can be installed with: pip install git+https://github.com/Pycord-Development/pycord@refs/pull/2919/head |
DA-344
force-pushed
the
fix/options-annotations
branch
from
404889a to
694de67
Compare
Signed-off-by: DA344 <[email protected]>
Soheab
reviewed
Sep 11, 2025
Lulalaby
requested changes
Sep 11, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where the Option class in Discord commands did not correctly resolve type annotations when they were provided as string literals or forward references (e.g., param: 'ForwardRefToSomeThing' or when using from __future__ import annotations).
- Adds support for resolving string-based type annotations using a new
resolve_annotationutility - Improves parameter validation by adding proper type hints and using iterators more efficiently
- Updates import statements to include necessary utilities and remove unused imports
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| discord/commands/core.py | Adds string annotation resolution logic, improves type hints, and cleans up imports |
| CHANGELOG.md | Documents the bug fix for string/forward reference annotation parsing |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
ping |
|
anyways, it doesnt work with custom classes |
Signed-off-by: Lala Sabathil <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Option did not correctly resolve the type of an annotation when it was typed like
param: 'ForwardRefToSomeThing'or when usingfrom __future__ import annotations.Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.